From e7df0579c298daf1eb3515379fc1fb5a03174ce6 Mon Sep 17 00:00:00 2001 From: Kristian Rietveld Date: Wed, 28 May 2008 14:47:50 +0000 Subject: [PATCH] Bug 449625 - crash in gtk_tree_view_real_move_cursor at gtktreeview.c:9641 2008-05-28 Kristian Rietveld Bug 449625 - crash in gtk_tree_view_real_move_cursor at gtktreeview.c:9641 * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): cursor_offset *must* be larger than background height of the cursor node, not just equal otherwise there is no guarantee there is a next node. svn path=/trunk/; revision=20219 --- ChangeLog | 10 ++++++++++ gtk/gtktreeview.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 1650156785..90db48a9fa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2008-05-28 Kristian Rietveld + + Bug 449625 - crash in gtk_tree_view_real_move_cursor at + gtktreeview.c:9641 + + * gtk/gtktreeview.c (gtk_tree_view_move_cursor_page_up_down): + cursor_offset *must* be larger than background height of the cursor + node, not just equal otherwise there is no guarantee there is a next + node. + 2008-05-28 Michael Natterer * gtk/gtktestutils.c: don't include . diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c index f4b4705aab..455a4fa3a7 100644 --- a/gtk/gtktreeview.c +++ b/gtk/gtktreeview.c @@ -9748,7 +9748,7 @@ gtk_tree_view_move_cursor_page_up_down (GtkTreeView *tree_view, _gtk_rbtree_find_offset (tree_view->priv->tree, y, &cursor_tree, &cursor_node); - if (tree_view->priv->cursor_offset >= BACKGROUND_HEIGHT (cursor_node)) + if (tree_view->priv->cursor_offset > BACKGROUND_HEIGHT (cursor_node)) { _gtk_rbtree_next_full (cursor_tree, cursor_node, &cursor_tree, &cursor_node); -- 2.30.2